build: fix Windows resource metadata names#338
Open
francosmit94-web wants to merge 1 commit into
Open
Conversation
|
Review-assist note for #32 / #81 / #338: This is a strong low-risk Windows packaging/metadata cleanup: the visible diff realigns the version-resource metadata for Acceptance checks I would keep explicit before merge/payout:
I did not run builds, install dependencies, start nodes, use wallet keys, or perform any live-chain action. This is a maintainer-facing review checklist to help decide whether #338 should be accepted as a focused Windows metadata fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes mismatched Windows version-resource metadata for BGL command-line tools:
The resource files were shifted across tools, so Windows file properties could show the wrong executable name/product metadata.
References #32.
Verification
git diff --check